- Issue created by @lelkneralfaro
- Status changed to Needs review
about 1 year ago 8:25am 21 April 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for reporting that issue!
We already have ✨ Support for entity reference filtering like TaxonomyIndexTid Postponed for adapting to that issue once it gets committed. Adapting existing code to be compatible with the changes of course has higher priority – though I guess this would only concern custom code using our filter trait as long as we don’t provide our own subclass of the new filter plugin. So, not sure if we need to concern ourselves with that.
On the other hand, of course, we needn’t even wait for that issue, but could add the return type right away – narrowing the return type in a sub class is legal, after all.
However, this in turn might affect custom code using our filter trait (though it might be that this would only be the case in pretty complex setups), so just adding a new return type isn’t a completely harmless step, either.All in all, I’m not sure how to proceed here. I’m open for input from anyone else!
- Status changed to Closed: won't fix
about 1 month ago 11:00am 6 April 2025 - 🇦🇹Austria drunken monkey Vienna, Austria
As far as I can tell, adding those return type hints was abandoned in the final version of the MR, so nothing for us to do here.