- Issue created by @aaronpinero
- πΊπΈUnited States itmaybejj
When the CSP maintainers sent that code over, CSP did not support hashes or nonces. It now does. β
If you would like to help convert Editoria11y to nonce/hash based allow options, or help CSP document how to do it π Provide a README Needs review , I would welcome the assistance.
- Status changed to Postponed: needs info
9 months ago 4:17pm 12 April 2024 - πΊπΈUnited States itmaybejj
Bah. I tried to get nonces working so that using nonces rather than hashes would be an option at least, but it looks like a lot of the relevant CSP module code has not landed and what has landed is not documented, so I didn't get far.
If you want to help with code or documentation, please do. Otherwise this issue might better be placed in the CSP module queue -- undocumented directives is going to guarantee module conflicts.
-
itmaybejj β
committed 419f7b01 on 2.1.x
Issue #3440514: CSP support solution conflicts with CSP hashes...
-
itmaybejj β
committed 419f7b01 on 2.1.x
- Assigned to itmaybejj
- Status changed to Needs review
8 months ago 7:41pm 16 April 2024 -
itmaybejj β
committed fe3e1473 on 2.1.x
Issue #3440514: CSP support solution conflicts with CSP hashes...
-
itmaybejj β
committed fe3e1473 on 2.1.x
-
itmaybejj β
committed e1c4bab1 on 2.1.x
Issue #3440514 by itmaybejj: CSP support solution conflicts with CSP...
-
itmaybejj β
committed e1c4bab1 on 2.1.x
- πΊπΈUnited States itmaybejj
Alrighty then. That last commit abstracts all the CSS back out into a remote file, which removes the need for any CSP hashes or nonces at all.
This was how I did things in the 1.x branch. It makes development much more complicated for this sort of module; it makes theme conflicts more likely, I have to inject duplicate references to the file into each shadow component, and I can no longer compute values based on params that can't be converted to CSS variables...but...it looks like it works. I'll need to test more and update the docs before tagging a release...hopefully within the week.
-
itmaybejj β
committed c988a1c3 on 2.1.x
Issue #3440514 by itmaybejj: CSP support solution conflicts with CSP...
-
itmaybejj β
committed c988a1c3 on 2.1.x
- Status changed to Fixed
8 months ago 7:54pm 18 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- πΊπΈUnited States aaronpinero
Thank you! I took a closer look at the original Sally code myself just to see what's going on here I think I understand why some of this was done the way it was done. I appreciate the effort to make it possible to run this with a CSP.