Cut a 2.x branch

Sounds great. +1

Great to see some movement in this module. I invite ya'll to check out https://drupal.org/project/diff_plus for anything that might be beneficial to include in a new major.

@Luke.Leber very keen to collaborate there! If there's anything you can point out that may be good candidates I'm all ears :)

Not sure if you want to include D10 deprecations in the scope of this issue, but this module does use entity_storage->loadRevisions(), which is removed in Drupal 11, per https://www.drupal.org/node/3294237 →

Located in the following files:
- /src/Controller/NodeRevisionController.php
- /src/Controller/PluginRevisionController.php
- /src/Form/RevisionOverviewForm.php
- /src/Plugin/views/field/DiffPluginBase.php

Some feature suggestions for 2.x:

A more extensible twig template based UI.

Presently, the UI can be rather spartan and cold compared to the implementations in other content management systems. Something as simple as user avatars can make a world of difference to non-technical users. Giving themes the ability to customize how the Diff UI looks is a sorely needed UX enhancement. This is how I heavy-handedly tackled this in diff_plus: https://git.drupalcode.org/project/diff_plus/-/blob/1.0.x/src/EventSubsc...

The default HTMLPurifier configuration just doesn't work very well sometimes.

I ditched HTMLPurifier in diff_plus and added some tweaks and toggles to make higher fidelity HTML5 complex content renderings ( https://git.drupalcode.org/project/diff_plus/-/blob/1.0.x/src/Plugin/dif... ).

There has never been a more opportune moment to make Diff entity agnostic.

Drupal isn't all about nodes anymore. We have all sorts of entity types in contrib and custom-land, now with a generic revision UI available, a major version bump seems like the right time to target getting all modernized here. This has not been tackled in diff_plus yet.

If these are too extreme, I'll gladly continue maintaining things in diff_plus, but just wanted to weigh in and let the maintainers know that I'm very open to collaboration.

Thanks.

@Luke.Leber great points, fully agree with the generic entity stuff, I just wish Node was using that already so it was even easier.

I am keen to explore other HTML diffing libraries, when I last checked the one this module uses is quite outdated?

This is done, the last thing I want to do before cutting an alpha is 📌 Investigate better HTML diffing libraries to replace HTMLPurifier Active

Making the module entity agnostic will come once Node uses the generic revision UI :) (in a 3.x branch perhaps)

Automatically closed - issue fixed for 2 weeks with no activity.