entity.workflow.delete_transition_form doesn't use _entity_form delete-transition

Created on 11 April 2024, 9 months ago

Problem/Motivation

The Workflow entity defines a delete-transition form handler. However, the entity.workflow.delete_transition_form route uses _form over _entity_form like the entity.workflow.edit_transition_form route.

Steps to reproduce

Try to decorate WorkflowTransitionDeleteForm and find you need to alter the route as well.

Proposed resolution

Use _entity_form.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Workflows →

Last updated 11 days ago

Maintained by
🇦🇺Australia @Sam152

Created by

🇺🇸United States mglaman WI, USA

Live updates comments and jobs are added and updated live.

Merge Requests

!7453entity.workflow.delete_transition_form doesn't use _entity_form delete-transition
Open
🇺🇸United States mglaman
updated 9 months ago

Comments & Activities

Issue created by @mglaman
Merge request !7453entity.workflow.delete_transition_form doesn't use _entity_form delete-transition → (Open) created by mglaman
Status changed to Needs review 9 months ago1:54pm 11 April 2024
Comment 9 months ago →
🇺🇸United States mglaman WI, USA
I don't think this needs additional tests.
Pipeline finished with Failed
9 months ago
Total: 1048s
#144005
Status changed to Needs work 9 months ago2:23pm 11 April 2024
Comment 9 months ago →
🇺🇸United States mglaman WI, USA
WorkflowTransitionDeleteForm does not extend EntityConfirmFormBase, which is why this is failing.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024