Do not assume that a file with the given target_id exists

Error: Call to a member function id() on null in /var/www/html/web/modules/contrib/file_url/src/Plugin/Field/FieldType/FileUrlFieldItemList.php on line 98 #0 [internal function]: Drupal\file_url\Plugin\Field\FieldType\FileUrlFieldItemList->postSave(true) #1 /var/www/html/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(939): call_user_func_array(Array, Array) #2 /var/www/html/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(985): Drupal\Core\Entity\ContentEntityStorageBase->invokeFieldMethod('postSave', Object(Drupal\node\Entity\Node), true) #3 /var/www/html/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(897): Drupal\Core\Entity\ContentEntityStorageBase->invokeFieldPostSave(Object(Drupal\node\Entity\Node), true) #4 /var/www/html/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(564): Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('update', Object(Drupal\node\Entity\Node)) #5 /var/www/html/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(781): Drupal\Core\Entity\EntityStorageBase->doPostSave(Object(Drupal\node\Entity\Node), true) #6 /var/www/html/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(489): Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object(Drupal\node\Entity\Node), true) #7 /var/www/html/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(806): Drupal\Core\Entity\EntityStorageBase->save(Object(Drupal\node\Entity\Node)) #8 /var/www/html/web/core/lib/Drupal/Core/Entity/EntityBase.php(354): Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object(Drupal\node\Entity\Node)) ...

Comments & Activities

Issue created by @huzooka
Merge request !6Resolve #3440231 "Handle missing target ids" → (Open) created by huzooka
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 3 months ago
5 pass
Issue was unassigned.
Status changed to Needs review 3 months ago1:58pm 11 April 2024
Comment 3 months ago →
🇭🇺Hungary huzooka Hungary 🇭🇺🇪🇺
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 3 months ago
5 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 3 months ago
2 pass, 1 fail
Comment 3 months ago →
🇭🇺Hungary huzooka Hungary 🇭🇺🇪🇺
Adding old-school patch files.
Comment 3 months ago →
System Message
The last submitted patch, 4: file_url-handle_missing_target_ids-3440231-2--test-only.patch, failed testing. View results →
Comment 2 months ago →
🇵🇹Portugal dxvargas
The work is good so far and it's solving the problem that is being reported. Good.

But the method "\Drupal\file_url\FileUrlHandler::urlToFile" is where the problem started. It declares that it always returns a FileInterface but it can also return NULL. And there are other usages of this method that can also raise errors because the NULL case is not being handled correctly.
I think this should also be fixed. Here or in another D.O issue. What do you think?

Do not assume that a file with the given target_id exists

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!6Do not assume that a file with the given target_id exists
Open

Comments & Activities

Do not assume that a file with the given target_id exists

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!6Do not assume that a file with the given target_id existsOpen

Comments & Activities

!6Do not assume that a file with the given target_id exists
Open