Refactor jsx_umami to use Vite

Created on 10 April 2024, 12 months ago
Updated 15 April 2024, 12 months ago

Problem/Motivation

Even though the JSX demo is not being served by node, there are still benefits such as having fs available that make it advantageous to have Vite as the build tool. Lets switch to Vite to expand the possibilities of this project.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Needs review

Version

1.0

Component

Umami JSX Demonstration Theme

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @bnjmnm
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia yash.rode pune

    yash.rode โ†’ made their first commit to this issueโ€™s fork.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia yash.rode pune

    I am following Migrate CRA to Vite, it is not completely working yet, but can someone verify if I am on the right track.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States bnjmnm Ann Arbor, MI

    The Migrate CRA to Vite has some good info, but probably shouldn't be followed too closely. Reasons include

    1. The Umami demo uses esbuild, not Create React App
    2. We're not serving anything via JS, this is strictly building. Things like running dev should still update when files change while using non-minified code, but Drupal is already doing the serving - no "application running on port x" needed
  • Pipeline finished with Success
    12 months ago
    Total: 1198s
    #142685
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia yash.rode pune

    If we refresh the page with current MR, we are getting Using the "css" tag in runtime is not supported. Make sure you have set up the Babel plugin correctly. this error, in the previous version where we were using esbuild

    linaria({
          esbuildOptions: {
            jsx: 'automatic',
        },
    })

    this code in create-react.mjsfixed the same problem, what is the equivalent of this in vite.config.ts?

  • Pipeline finished with Failed
    12 months ago
    Total: 961s
    #144767
  • Pipeline finished with Canceled
    12 months ago
    Total: 1197s
    #144869
  • Pipeline finished with Failed
    12 months ago
    Total: 1036s
    #144888
  • Pipeline finished with Failed
    12 months ago
    Total: 1001s
    #146768
  • First commit to issue fork.
  • Pipeline finished with Failed
    12 months ago
    Total: 1149s
    #146848
  • Pipeline finished with Canceled
    12 months ago
    Total: 669s
    #146914
  • Status changed to Needs review 12 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia yash.rode pune

    dev, build:react-dev and build:react all three scripts are running with vite now.

  • Pipeline finished with Failed
    12 months ago
    Total: 1870s
    #146933
Production build 0.71.5 2024