StandardPerformanceTest::testAnonymous is hard to get to pass locally

OK this subtly changes all the test assumptions but it specifically does get rid of those two queries so hopefully this will get consistent results on @alexpott's local too. I'm not able to run functional js tests locally at the moment because chromedriver keeps crashing all the time (and didn't figure out why), so excuse all the commits here.

Remove a couple of assertBetween() too since ideally we don't need to do that any more.

After doing all this, I realised adding an extra sleep() after the first request might have been enough... this is probably better than doing that.

I'm getting an error with this

ArgumentCountError: Too few arguments to function Drupal\Core\ProxyClass\Lock\DatabaseLockBackend::wait(), 0 passed in /Volumes/dev/sites/drupal8alt.dev/core/modules/system/tests/modules/performance_test/src/PerformanceDataCollector.php on line 74 and at least 1 expected in Drupal\Core\ProxyClass\Lock\DatabaseLockBackend->wait() (line 113 of core/lib/Drupal/Core/ProxyClass/Lock/DatabaseLockBackend.php).

#5 reveals a bug we merged a while ago. Odd.

As soon as I got this back to green, it ran into merge conflicts. But then I tried to fix chromedriver locally again and may have done so finally, (increased shm_size in docker for the chromedriver image) -hopefully back to green again.

The lock wait issue can only happen if two requests are trying to write performance data at the same time, which should no longer be happening when we're trying to actually collect data to assert on, but could be happening in the initial cold cache requests where we warm up.

Re-did the locking logic slightly so it at least shouldn't error.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased.

This works great and passes locally for me. Nice!

Committed 4d00efb and pushed to 11.x. Thanks!
Committed 35b7c9f and pushed to 10.3.x. Thanks!

longwave → closed merge request !7393

Automatically closed - issue fixed for 2 weeks with no activity.