- Issue created by @acbramley
- πͺπΈSpain fjgarlin
Code:
- https://git.drupalcode.org/project/drupalorg/-/blob/7.x-3.x/drupalorg/dr..., if a user can edit an issue they can click on "hide"
- And then the function https://git.drupalcode.org/project/drupalorg/-/blob/7.x-3.x/drupalorg/dr... checks for a token and proceeds.
- The link is rendered like this: https://git.drupalcode.org/project/drupalorg/-/blob/7.x-3.x/drupalorg/in...Possible cause:
The only explanation was that the token was stale/expired and they got the 403. If they get it afterwards, that might be a caching issue on that browser. Thought they mentioned trying on different browsers, which makes it weird, as the token should be different. - πͺπΈSpain fjgarlin
Replied in slack thread to both affected users: https://drupal.slack.com/archives/CGKLP028K/p1712565892781179?thread_ts=...
so, it seems to be related to the token in the link being expired/stale.
possible workarounds:
- hard refresh
- edit the issue with something else and then try againitβs defo a caching issue, but itβs weird that both you and Max are getting it, even on different browsers.
Can you or Max try again:
- loading https://www.drupal.org/project/drupal/issues/1383696?1 β (note the ?1)
- and then again with https://www.drupal.org/project/drupal/issues/1383696 β¨ Allow a custom HTML element to be selected for a grouping field Needs work (no ?1, just normal URL)? - πͺπΈSpain fjgarlin
I tried myself in that issue and I also get the 403, on any of the "hide" links. I always get "Invalid token". I've tried in other issues and I can "hide" without any problem, so it seems to be just this one.
So I wonder if there is some weird fastly catching issue going on. I'll wait to have @drumm's opinion on this.
- πͺπΈSpain fjgarlin
I found the issue. Branches created in the fork have the character
/
in them. I tried in the visible branch that didnβt have it and it worked. - πͺπΈSpain fjgarlin
This is now ready to test.
MR:
Test URL: https://fjgarlin-drupal.dev.devdrupal.org/project/config_notify/issues/3... - πͺπΈSpain fjgarlin
fjgarlin β changed the visibility of the branch 3439341-gitlab-branch-hide to hidden.
- Status changed to Needs review
about 1 year ago 2:26pm 8 April 2024 - First commit to issue fork.
-
drumm β
committed 1cdcf6e2 on 7.x-3.x authored by
fjgarlin β
Issue #3439341: GitLab branch hide button needs branch name encoded
-
drumm β
committed 1cdcf6e2 on 7.x-3.x authored by
fjgarlin β
- Status changed to Fixed
about 1 year ago 11:28pm 9 April 2024 - π¦πΊAustralia acbramley
Nice work! Confirming I can hide those branches on that issue now :)
-
drumm β
committed 1cdcf6e2 on owner-tools-fix-post-dcp-change-1 authored by
fjgarlin β
Issue #3439341: GitLab branch hide button needs branch name encoded
-
drumm β
committed 1cdcf6e2 on owner-tools-fix-post-dcp-change-1 authored by
fjgarlin β
Automatically closed - issue fixed for 2 weeks with no activity.