Add custom attributes to scripts in order to have more control over their execution

Removed the "required" property from the new field in the configuration form.

sujan shrestha → made their first commit to this issue’s fork.

Hi @enchufe, thank you for the new feature request and for providing the patch for 'custom attributes to scripts' feature.

I have implemented the Xss::filter() function to properly sanitized before using raw to output the $script_attributes value. Here's how it's applied on the module file:

$script_attributes = Xss::filter($script_attributes);

Additionally, I've utilized the 'raw' filter like {{ script_attributes|raw }} on the twig file to display the HTML-encoded script attributes. For example, type="text/plain" data-category="analytics" was displayed as show on the attachment screenshot.

If attributes are added in TWIG as raw, they are not displayed in the final HTML, and the async attribute is displayed as async="true".

Source: drupal/ga4_google_analytics:dev-1.1.x

@enchufe thanks for the issue, was looking for this!
How do you solve the delayed loading of any given script provided by a module (when consent was not yet given), simply by its attributes? Any hook I don't know of yet?

@florianmuellerCH To manage Cookies I use the JavaScript library orestbida/cookieconsent. The GA4 beacon is loaded with the attributes type=text/plain data-category=analytics. And the rest is configured by the library by activating the script (removing type=text/plain) when consenting to Cookies.
This gave me quite a headache, I hope it helps!

@enchufe that is simply pure gold, thank you so much! You saved me a loooot of headache!

And for the issue, I now use the dev branch and the change works absolutely fine, so I think it could be released. Could this be closed, or RTBC?

Automatically closed - issue fixed for 2 weeks with no activity.