Contrib.social

Clean up code/Fix build issues

Open on Drupal.org →
Created on 6 April 2024, 12 months ago
Updated 25 April 2024, 12 months ago

Problem/Motivation

We have added Drupal CI/CD in https://www.drupal.org/project/twig_svg/issues/3439026 📌 CI/CD template Fixed

There are 3 of the implemented builds failing. We should clean these up

phpcs - https://git.drupalcode.org/project/twig_svg/-/jobs/1258523

FILE: ...ject/twig_svg/web/modules/custom/twig_svg/src/Form/TwigSvgSettingsForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first
    |         |     wrong one is Drupal\Core\Config\ConfigFactoryInterface.
    |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
 21 | WARNING | [ ] Possible useless method overriding detected
    |         |     (Generic.CodeAnalysis.UselessOverridingMethod.Found)
 47 | WARNING | [x] A comma should follow the last multiline array item. Found:
    |         |     'twig.svg' (Drupal.Arrays.Array.CommaLastItem)

cspell - https://git.drupalcode.org/project/twig_svg/-/jobs/1258526

./README.md:7:51      - Unknown word (dont)       -- relative to the site root (dont include a forward slash
	 Suggestions: [dent, dint, doit, dolt, dona]

phpstan - https://git.drupalcode.org/project/twig_svg/-/jobs/1258524 

Line   src/Form/TwigSvgSettingsForm.php                                              
 ------ ------------------------------------------------------------------------------ 
  30     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom aaron.ferris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024