- Issue created by @drunken monkey
- Status changed to Needs review
9 months ago 4:07pm 9 April 2024 - last update
9 months ago 31 pass - last update
9 months ago 31 pass - 🇦🇹Austria drunken monkey Vienna, Austria
Looks mostly good. A few notes, all addressed in the attached patch revision.
-
+++ b/src/EventSubscriber/SearchApiSubscriber.php @@ -20,24 +21,29 @@ class SearchApiSubscriber implements EventSubscriberInterface { + $mapping['solr_text_custom'] = $mapping['text'];
Should
solr_text_custom_omit_norms
be included here, too? -
+++ b/src/Plugin/search_api/backend/SearchApiSolrBackend.php @@ -776,6 +776,7 @@ class SearchApiSolrBackend extends BackendPluginBase implements SolrBackendInter + 'solr_text_custom',
I assume this should have the
solr_text_custom_omit_norms
type, too? -
+++ b/src/Plugin/search_api/data_type/CustomTextDataType.php @@ -11,7 +11,7 @@ use Drupal\search_api\Plugin\search_api\data_type\TextDataType; - * fallback_type = "text", + * fallback_type = "search_api_text",
For all of those: Fallback types should be Search API data types, so those are already correct as-is.
-
- last update
9 months ago 31 pass -
mkalkbrenner →
committed 49764108 on 4.x
Issue #3439023 by mkalkbrenner, drunken monkey: Invalid types "text" and...
-
mkalkbrenner →
committed 49764108 on 4.x
- Status changed to Fixed
9 months ago 1:46pm 10 April 2024 -
mkalkbrenner →
committed 2bc4315d on 4.x
Issue #3439023 by mkalkbrenner, drunken monkey: Invalid types "text" and...
-
mkalkbrenner →
committed 2bc4315d on 4.x
Automatically closed - issue fixed for 2 weeks with no activity.