- Issue created by @mparker17
- Merge request !127Issue #3438899: Add isEmpty() function to ConditionGroupInterface β (Merged) created by mparker17
- Status changed to Needs review
9 months ago 2:03pm 5 April 2024 - π¦πΉAustria drunken monkey Vienna, Austria
drunken monkey β made their first commit to this issueβs fork.
- π¦πΉAustria drunken monkey Vienna, Austria
Thanks a lot for creating the issue and MR.
Your code already looks pretty good, just some code style issues. However, if we have that method, we should aim to cover all cases, so it would be great to also returnFALSE
if a condition group contains nothing but other empty condition groups. In that case, no condition would be added to the query, but$this->conditions
is non-empty. I amended that, explained it in the doc comment and also added a bit more of testing.Please review and Iβll merge. Thanks again, in any case!
- Status changed to RTBC
9 months ago 1:18pm 8 April 2024 - π¨π¦Canada mparker17 UTC-4
That makes sense to me! Thanks @drunken monkey!
- Status changed to Fixed
8 months ago 4:48pm 20 April 2024 - π¦πΉAustria drunken monkey Vienna, Austria
Great to hear, thanks for reporting back!
Merged. Thanks again! -
drunken monkey β
committed 844db5a4 on 8.x-1.x authored by
mparker17 β
Issue #3438899 by mparker17, drunken monkey: Added isEmpty() function to...
-
drunken monkey β
committed 844db5a4 on 8.x-1.x authored by
mparker17 β
Automatically closed - issue fixed for 2 weeks with no activity.