- Issue created by @pinesso
- First commit to issue fork.
- Merge request !18Fix: Use backend-configured Thousand Marker in statistics block โ (Open) created by Unnamed author
- ๐ฎ๐ณIndia calcifer_3119 Delhi
I've implemented the proposed fix for the Thousand Marker issue in the statistics block. The statistics-counter.js has been updated to use the backend-configured Thousand Marker via a new data-thousand-marker attribute.
Please review the changes and let me know if further adjustments are needed.
- ๐ง๐ทBrazil pinesso
Hi @calcifer_3119 โ ,
I believe you are missing the twig on the request. Can you please double check?
Ty!
- ๐ฎ๐ณIndia calcifer_3119 Delhi
Hi @pinesso,
Thank you for pointing that out. You were absolutely rightโI missed including the Twig updates initially. However, Iโve now addressed the issue, and everything should be working as expected. Please let me know if you encounter any further concerns!
Ty! - ๐ง๐ทBrazil pinesso
Hi @calcifer_3119 โ ,
Thank you for the quick response on this!
I'll check and get back to you!
Ty!
- ๐ง๐ทBrazil pinesso
Hi @calcifer_3119 โ ,
I was checking you MR and it seems not working yet.
Please check my test โ .
Am I missing something?
Also, I was trying to add the stats block using block layout and Layout builder. I'm wondering if we are missing something here. I tried to debug and I couldn't find the thousand_marker config. Please, check the image below
Ty!