Drupal 11 compatibility

Created on 3 April 2024, 8 months ago
Updated 8 May 2024, 7 months ago

Problem/motivation

As part of 🌱 [META] Roadmap for 3.x branch Active , let's provide Drupal 11 compatibility in the 3.x branch of this module. We should also remove explicit support for Drupal 9 (and PHP 7 by extension).

Proposed resolution

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.
✨ Feature request
Status

Fixed

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mark_fullmer
  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    FILE: /Users/jmf3658/Sites/url_embed/src/Form/UrlEmbedCke5Dialog.php
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
    75 | WARNING | Implicitly marking a parameter as nullable is deprecated since
    | | PHP 8.4. Update the type to be explicitly nullable instead.
    | | Found implicitly nullable parameter: $editor.
    --------------------------------------------------------------------------------

    FILE: /Users/jmf3658/Sites/url_embed/src/UrlEmbed.php
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
    34 | WARNING | Implicitly marking a parameter as nullable is deprecated since
    | | PHP 8.4. Update the type to be explicitly nullable instead.
    | | Found implicitly nullable parameter: $config_factory.
    --------------------------------------------------------------------------------

    Time: 4.24 secs; Memory: 14MB

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    Looks like tests are failing on Drupal 10.2.x but passing after that (e.g., 10.3.x, Drupal 11) because the conversion from Annotation to Attributes per https://www.drupal.org/node/3395575 β†’ lands in 10.3.

    Does that mean that the minimum version compatibility would need to be Drupal 10.3? Or is there a backward-compatible method for providing Annotations _and_ Attributes?

  • Status changed to Needs review 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson
  • Pipeline finished with Skipped
    7 months ago
    #155606
  • Status changed to Fixed 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024