- Issue created by @mark_fullmer
- πΊπΈUnited States mark_fullmer Tucson
FILE: /Users/jmf3658/Sites/url_embed/src/Form/UrlEmbedCke5Dialog.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
75 | WARNING | Implicitly marking a parameter as nullable is deprecated since
| | PHP 8.4. Update the type to be explicitly nullable instead.
| | Found implicitly nullable parameter: $editor.
--------------------------------------------------------------------------------FILE: /Users/jmf3658/Sites/url_embed/src/UrlEmbed.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
34 | WARNING | Implicitly marking a parameter as nullable is deprecated since
| | PHP 8.4. Update the type to be explicitly nullable instead.
| | Found implicitly nullable parameter: $config_factory.
--------------------------------------------------------------------------------Time: 4.24 secs; Memory: 14MB
- Merge request !16Issue #3272702 by stefanos.petrakis, Berdir, emptyvoid, chrisolof: Support for... β (Merged) created by mark_fullmer
- πΊπΈUnited States mark_fullmer Tucson
Looks like tests are failing on Drupal 10.2.x but passing after that (e.g., 10.3.x, Drupal 11) because the conversion from Annotation to Attributes per https://www.drupal.org/node/3395575 β lands in 10.3.
Does that mean that the minimum version compatibility would need to be Drupal 10.3? Or is there a backward-compatible method for providing Annotations _and_ Attributes?
- Status changed to Needs review
8 months ago 10:56pm 3 April 2024 -
mark_fullmer β
committed 9b1b5425 on 3.x
Issue #3437984: Drupal 11 compatibility
-
mark_fullmer β
committed 9b1b5425 on 3.x
- Status changed to Fixed
7 months ago 4:23pm 24 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.