Allow tasks to return a not run state

Open on Drupal.org →

Created on 3 April 2024, 3 months ago

Updated 17 April 2024, 2 months ago

Problem/Motivation

Tasks currently return bool|array<string, bool>, meaning that if a task does not meet the correct requirements it must return a failure.

Proposed resolution

Allow tasks to return null|bool|array<string, bool>, with null indicating a not run state.

API changes

The return signature for tasks will change to null|bool|array<string, bool>.
The method \Drupal\reviewer\Reviewer\Status\StatusFactory::createNoResults will be renamed createNotRun.
The method \Drupal\reviewer\Reviewer\Status\StatusEvaluator::isNoResults will be renamed isNotRun.

✨ Feature request

Status

Fixed

Version

1.1

Component

Code

Created by

🇺🇸United States benabaird

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!18Allow tasks to return a not run state
Merged
🇺🇸United States benabaird
updated 3 months ago

Comments & Activities

Issue created by @benabaird
Comment 3 months ago →
🇺🇸United States benabaird
Comment 3 months ago →
🇺🇸United States benabaird
Merge request !18Rename \Drupal\reviewer\Reviewer\Status\Status::NoResults status to... → (Merged) created by benabaird
Pipeline finished with Skipped
3 months ago
#135865
Comment 3 months ago →
System Message

benabaird → committed b0649d06 on 1.1.x
Issue #3437741: Allow tasks to return a not run state
Status changed to Fixed 3 months ago3:17am 3 April 2024
Comment 3 months ago →
🇺🇸United States benabaird
Failed test is due to no Drush support in Drupal 11 yet. Merging.
Comment 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024