Daily automated core config validatability report broke on March 23

Created on 2 April 2024, 3 months ago
Updated 17 April 2024, 2 months ago

Problem/Motivation

Something changed significantly between f0dfe7d49a and ce9ec037b7 in 11.x:

…
🤖                               Reinstalling Composer packages (including Drush) because composer.lock has changed…
🕰️  2024-03-19 00:00:00 +00:00 → 35.58% (e84fc608c2 Issue #2893568 by Wim Leers, lee.cocklin, AaronBauman, anon, ainarend: Linking in CKEditor 5: URLs with top-level domain but without protocol …)
🕰️  2024-03-20 00:00:00 +00:00 → 35.58% (9c9935d05d Issue #3432052 by catch: @group slow for more Kernel tests)
🕰️  2024-03-21 00:00:00 +00:00 → 35.58% (f0dfe7d49a Issue #3432298 by kostyashupenko, smustgrave: Sticky table header is not sticky if --drupal-displace-offset-top is not defined)
🤖                               Installing DB updates…
🤖                               Erasing discovery cache because config schema changed…
🤖                               Rebuilding container because validation constraints were added or modified…
🤖                               Rebuilding container because kernel infrastructure changed…
🕰️  2024-03-22 00:00:00 +00:00 → 35.58% (ce9ec037b7 Issue #3415582 by nico.b, larowlan, Matt B: Unhandled exception when trying to register a duplicate username with different case)
 [error]  {
    "assessment": {
        "_description": "Default assessment generated from these statistics.",
        "typesFullyValidatable": 0.06654676258992806,
        "typesInUse": 0.3902877697841727,
        "typesInUsePartiallyValidatable": 0.9493087557603687,
        "typesInUseFullyValidatable": 0.12903225806451613,
        "typesInUsePropertyPathsFullyValidatable": 0.037146843390303455,
        "typesInUseImplicitlyFullyValidatable": 0.09216589861751152,
        "objectPropertyPathsValidatable": 0.5870247645622602,
        "objectPropertyPathsFullyValidatable": 0.037146843390303455,
        "objectsImplicitlyFullyValidatable": 0.20441988950276244,
        "objectsFullyValidatable": 0.19337016574585636
    },
    "types": {
…

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

2.1

Component

Code

Created by

🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Wim Leers
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    Not currently mergeable.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    3 pass
  • Status changed to Needs work 3 months ago
  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
    variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
    

    … but --statistics never prints that output!

    That made it much harder to track down than it should've been. Fixed that bit in the MR already. Now to track down the root cause…

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    3 pass
  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    … actually, the root cause is much simpler and happens after March 23, when it tries to assess revision d671f38a0e4b563:

     [error]  Error: Class "Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginManager" not found in Drupal\Component\DependencyInjection\Container->createService() (line 258 of /Users/wim.leers/core/core/lib/Drupal/Component/DependencyInjection/Container.php) #0 /Users/wim.leers/core/core/lib/Drupal/Component/DependencyInjection/Container.php(444): Drupal\Component\DependencyInjection\Container->createService(Array, 'plugin.manager....')
    

    … due to 📌 [11.x] Remove the CKEditor 4 upgrade path Fixed .

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    It's the commit of 🐛 Page title should contextualize the local navigation Needs work and subsequent revert that exposed this weakness:

    • block_post_update_add_base_route_title_page_title() updated all page_title_block blocks
    • … and type: block.settings.page_title_block was defined too, so all was well!
    • BUT then that commit was reverted in 192c0f5dea648097c6c2191e67f2622ba2acb6a2, which subsequently caused the update path to be reverted too, now leaving the updated config in a non-compliant state!
  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    Yay, got past that!

    The next problem occurs ~1 week later:

    🕰️  2024-03-28 00:00:00 +00:00 → 35.80% (e1e95969a1 Issue #3352256 by e0ipso, plopesc, bbrala, longwave, dww, catch, larowlan: Move code from the experimental SDC module to core)
    PHP Fatal error:  Uncaught Error: Class "Drupal\Core\EventSubscriber\RequestCloseSubscriber" not found in /builds/project/config_inspector/core/lib/Drupal/Component/DependencyInjection/Container.php:258
    Stack trace:
    #0 /builds/project/config_inspector/core/lib/Drupal/Component/DependencyInjection/Container.php(176): Drupal\Component\DependencyInjection\Container->createService(Array, 'request_close_s...')
    #1 /builds/project/config_inspector/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(105): Drupal\Component\DependencyInjection\Container->get('request_close_s...')
    #2 /builds/project/config_inspector/vendor/symfony/http-kernel/HttpKernel.php(115): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object(Symfony\Component\HttpKernel\Event\TerminateEvent), 'kernel.terminat...')
    #3 /builds/project/config_inspector/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(63): Symfony\Component\HttpKernel\HttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
    #4 /builds/project/config_inspector/core/lib/Drupal/Core/DrupalKernel.php(679): Drupal\Core\StackMiddleware\StackedHttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
    #5 /builds/project/config_inspector/vendor/drush/drush/src/Boot/DrupalBoot8.php(326): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
    #6 [internal function]: Drush\Boot\DrupalBoot8->terminate()
    #7 {main}
      thrown in /builds/project/config_inspector/core/lib/Drupal/Component/DependencyInjection/Container.php on line 258
    🤖                               Erasing discovery cache because config schema changed…
    🤖                               Rebuilding container because validation constraints were added or modified…
    🤖                               Rebuilding container because services changed…
    🕰️  2024-03-29 00:00:00 +00:00 → 35.97% (56141280b4 Issue #3436761 by simohell: Remove default event from collpased nav-tabs button)

    Due to the changes committed in 📌 Replace RequestCloseSubscriber with needs_destruction tag on ModuleHandler Fixed , which Drush is affected by. But … this does not cause a hard crash, and everything continues just fine 👍

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 3 months ago
    PHPLint Failed
  • Issue was unassigned.
  • Status changed to RTBC 3 months ago
  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    If PHP 8.3 works for 11.x going back to November 2022 … we'd be good to go 🤞

  • Pipeline finished with Skipped
    3 months ago
    #136136
    • Wim Leers committed a1b810b7 on 2.1.x
      Issue #3437731: Daily automated core config validatability report broke...
  • Status changed to Fixed 3 months ago
  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024