- Issue created by @coaston
- Assigned to abhishek_virasat
- Issue was unassigned.
- Status changed to Needs review
9 months ago 5:45am 1 April 2024 - 🇮🇳India abhishek_virasat
@coaston , I have fixed the issue please review the patch file
- First commit to issue fork.
- Merge request !47Issue #3437107: Fix Undefined array key "view_mode" warning. → (Open) created by manish-31
- 🇮🇳India manish-31
@abhishek_gupta1 Thanks for the patch!
Made one change : setting
default
instead ofNULL
when view mode is not available in widget settings.I have raised MR for the fix. Needs review.
- 🇺🇸United States apmsooner
Theres actually a better fix for this and other related tickets that I will push up here in a bit. First off, this formatter needs to have default settings merged in with actual settings and then view_mode will always exist. The bigger underlying issue is in the base formatter as it needs to respond to field changes and serve the default formatter in case the already saved formatter doesn't relate to the field type. I will tag that issue in a separate ticket and link these up but this should resolve all formatter issues.
- Status changed to Fixed
9 months ago 3:33pm 4 April 2024 - 🇺🇸United States apmsooner
Addressed in this commit: https://git.drupalcode.org/project/custom_field/-/commit/bc7495df778829b.... You can test latest dev branch to confirm and reopen separate issue if you are still seeing problems but this should be resolved now with the default settings merged in.
- Status changed to Fixed
9 months ago 6:30pm 4 April 2024