- Issue created by @tedbow
- Status changed to Needs review
about 1 year ago 7:13pm 29 March 2024 - Assigned to phenaproxima
- Assigned to tedbow
- Status changed to Needs work
about 1 year ago 3:36pm 3 April 2024 - πΊπΈUnited States phenaproxima Massachusetts
Not a lot of complaints here. I'm not a huge fan of the way the validator itself is written, but it's also a direct copy from Automatic Updates so it's out of scope here.
- πΊπΈUnited States tedbow Ithaca, NY, USA
@phenaproxima re
how do we account for dependencies being updated?
This validator is not concern with dependencies being updated. It only deals with the packages that directly request to be updated. This validator like the one in automatic_updates are really just fail safe in the case that Composer operation succeeded but for some reason the directly requested projects were not updated we should fail.
I added updates to other packages in the test to prove these are allowed.
- Assigned to phenaproxima
- Status changed to Needs review
about 1 year ago 6:25pm 3 April 2024 - Assigned to tedbow
- Status changed to RTBC
about 1 year ago 7:11pm 3 April 2024 - πΊπΈUnited States phenaproxima Massachusetts
Okay, that explanation makes sense to me.
-
tedbow β
committed b5cf0c88 on 3.0.x
Issue #3437023: Copy RequestedUpdateValidator to...
-
tedbow β
committed b5cf0c88 on 3.0.x
- Status changed to Fixed
about 1 year ago 7:17pm 3 April 2024 -
tedbow β
authored c3f1ced2 on 3.1.x
Issue #3437023: Copy RequestedUpdateValidator to...
-
tedbow β
authored c3f1ced2 on 3.1.x
Automatically closed - issue fixed for 2 weeks with no activity.