Fixing outdated entities issue after update to version 1.11

Open on Drupal.org →

Created on 28 March 2024, 9 months ago

Updated 4 August 2024, 5 months ago

Problem/Motivation

After updating to version 1.11, I noticed that sometimes I was getting outdated information. My tests flagged this issue, and I discovered it's because of a change made in #3098924.

Previously, the system fetched the latest data directly from the database. Now, it retrieves related data from the current object, which might not be up-to-date.

Steps to Reproduce

Here's what happened in my case:

1) I added a paragraph field to an order item.
2) In my service, I changed the content of this paragraph and saved it.

What I expected: When I accessed the paragraph later, I expected to see the updated version.
What actually happened: I got the old version of the paragraph, which didn't reflect the changes I made.

Proposed Resolution

Short-term: We can revert the changes introduced in #3098924 🐛 referencedEntities() causes data loss Needs review . This will bring back the old method of fetching data directly from the database, which is more reliable.

Long-term: We should keep an eye on the ongoing discussion in #2826717 🐛 EntityReferenceFieldItemList::referencedEntities might not return up-to-date entity objects Needs work . This issue is exploring ways to improve the current approach of fetching data. Once a solution is ready, we can either use it directly or adapt it to work with revisions.

This approach ensures that we have a working solution in the short term while also working towards a more robust and sustainable solution in the long term.

🐛 Bug report

Status

Postponed

Version

1.0

Component

Code

Created by

🇺🇦Ukraine reflie

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!47Fixing outdated entities issue after update to version 1.11
Open
🇺🇦Ukraine reflie
updated 9 months ago

Comments & Activities

Issue created by @reflie
Merge request !47Issue #3436645: Fixing outdated entities issue after update to version 1.11 → (Open) created by reflie
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 9 months ago
40 pass
Status changed to Needs review 9 months ago10:31am 28 March 2024
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 9 months ago
40 pass
Comment 9 months ago →
🇺🇦Ukraine reflie
Adding a patch with the same changes made within the fork.
Status changed to Postponed 5 months ago8:49am 4 August 2024
Comment 5 months ago →
🇨🇭Switzerland berdir Switzerland
I understand this is a BC break, but the original issue fixed a different kind of bug that people were also experiencing and this behavior is consistent with core ER fields and the behavior of statically cached entities in general. I would expect this mostly affects test and not real sites, because it's only an issue with long-living processes while other processes are applying changes.

Postponed on the core issue, if there's a change there then I'm willing to revisit this.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024