- Issue created by @GaëlG
- last update
about 1 year ago 36 pass, 8 fail - last update
about 1 year ago 75 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:47pm 5 April 2024 - 🇫🇷France GaëlG Lille, France
Actually my second idea seemed easier to do: if a config exists by default (in sync) but not when the split is active, we config-split:export that config as an empty array yaml file. Then on config import, we delete this config if it exists, in case we detect an empty array.
I made some manual testing, for my use case but also for a "normal" config entity (not a translation one). It seems to work well. But I would not be surprised if my code has problems I did not expect. This code seems complex to me and I think it's the first time I contribute to it. I was not always sure of the meaning of every line, some where sort-of copy-pasted.
Anyway, I made a merge request. But even if the idea is OK and the implementation is OK too, I guess tests would be needed?
The good news is that this would give a new feature: remove a config only in a split.
- Status changed to Needs work
12 months ago 7:13am 25 April 2024 - 🇨🇭Switzerland bircher 🇨🇿
we should definitely have a test for that! It would help me step through the code and find more edge cases.
- Status changed to Needs review
5 months ago 11:46am 15 November 2024 - 🇫🇷France GaëlG Lille, France
Hello bircher, I made tests and added some comments to the MR.
- Status changed to Needs work
about 1 month ago 8:28am 26 February 2025 - 🇫🇷France prudloff Lille
I resolved the conflicts but now tests are failing.