watchdog_exception() is not replaced properly

Drupal version

Rector's patch want to make this change:

- watchdog_exception('module_builder', $e); + \Drupal\Component\Utility\DeprecationHelper::backwardsCompatibleCall(\Drupal::VERSION, '10.1.0', fn() => \Drupal\Core\Utility\Error::logException(\Drupal::logger('module_builder'), $e), fn() => watchdog_exception('module_builder', $e));

$logger = \Drupal::logger('update'); Error::logException($logger, $exception);

Comments & Activities

Issue created by @joachim
Comment 10 months ago →
🇵🇹Portugal jcnventura
I think that the change is actually good like that. Doing the replacement in the CR will force the .info.yml to be only "^10.1 || ^11". Either rector does that change in the .info.yml or it stays as is and rector can simply append "|| ^11" to the current core_version_requirement.
Comment 10 months ago →
🇳🇱Netherlands bbrala Netherlands
Yes this change is because of backwards compatiblity. If you run rector on Drupal version that is higher than the version the function was deprecated in it will not add the BC layer.
Comment 10 months ago →
🇳🇱Netherlands bbrala Netherlands
Status changed to Closed: works as designed 10 months ago9:32am 7 June 2024
Comment 10 months ago →
🇳🇱Netherlands bbrala Netherlands

watchdog_exception() is not replaced properly

Drupal version

Drupal Rector version

Problem / Motivation

Comments & Activities