Automated Drupal 11 compatibility fixes for search_api_solr forwarded from search_api

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

Search API will unfortunately need to add an array return type hint to BackendPluginBase::__sleep() (see #3425235-12: Make the Search API module compatible with Drupal 11 → ), so the Solr backend will need to do the same in order to avoid a fatal error.

I’m not quite sure yet when I’ll merge my Search API issue, but it would be good to get this fix in for the Solr module as soon as possible.

If you target 8.1+ perhaps https://www.php.net/manual/en/class.returntypewillchange.php is something you could look at? Not sure.

If you target 8.1+ perhaps https://www.php.net/manual/en/class.returntypewillchange.php is something you could look at? Not sure.

I had already tried that, but no dice. As the docs say, this can only be used to silence deprecation notices, not avoid fatal errors. (Not sure how it actually can be used, to be honest. It didn’t seem to do anything no matter what I tried.)

+++ b/tests/src/Functional/ViewsTest.php
@@ -29,6 +29,7 @@ class ViewsTest extends SearchApiViewsTest {
+    parent::setUp();

This is wrong.I'll remove it on commit.

+++ b/modules/search_api_solr_devel/src/Controller/DevelController.php
@@ -203,7 +203,7 @@ public function entitySolr(RouteMatchInterface $route_match) {
+                      $summary_row['object_size'] = \Drupal\Component\Utility\DeprecationHelper::backwardsCompatibleCall(\Drupal::VERSION, '10.2.0', fn() => \\Drupal\Core\StringTranslation\ByteSizeMarkup::create(strlen(json_encode($fields))), fn() => format_size(strlen(json_encode($fields))));

parse error

If you set this issue to fixed you will not received any updates when new deprecations are added or supported.

Either keep the issue open or remove the tags from the issue so it will update this issue or create a new one.

Just noticed the tags are gone. Sorry.

This is duplicate!
The original issue is still open.

Automatically closed - issue fixed for 2 weeks with no activity.