Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.json

Issue created by @jonathan1055
Merge request !124Issue #3432976 Investigate / fix ESLINT coding standards → (Merged) created by jonathan1055
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
227 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
227 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
227 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
227 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
Javascript coding standards error
Pipeline finished with Failed
11 months ago
#150862
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
Javascript coding standards error
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
227 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
227 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
227 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
227 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
227 pass
Status changed to Needs review 11 months ago12:14pm 19 April 2024
Comment 11 months ago →
🇬🇧United Kingdom jonathan1055
The .eslintignore file is still required for DrupalCI tests to pass, because the improved ESlint configuration used in Gitlab pipelines is NOT used in the DrupalCI. The file is deleted in the Composer job in the pipeline, so that the files are not ignored in the pipeline job.
Comment 11 months ago →
🇬🇧United Kingdom jonathan1055
Testing on DrupalPod seems to show that the javascript is not working any more with these eslint fixes.
Status changed to Needs work 11 months ago4:11pm 19 April 2024
Comment 11 months ago →
🇬🇧United Kingdom jonathan1055
This is what we get before the changes in this MR
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
229 pass, 2 fail
Comment 10 months ago →
🇬🇧United Kingdom jonathan1055
We now have test coverage for the above problem, added in
📌 Expand javascript test coverage Fixed
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
237 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
237 pass
Comment 10 months ago →
🇬🇧United Kingdom jonathan1055
Due to the differing eslint config rules, if the files are fixed for eslint on GitLab pipelines, they fail on DrupalCI. So the .eslintignore file will stay in place (to make sure the DrupalCI eslint does not fail) but the file is deleted in a custom composer: after_script: so that the three ,js files are ignored in the gitlab eslint job.
Pipeline finished with Skipped
10 months ago
#166408
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
237 pass
Comment 10 months ago →
System Message

jonathan1055 → committed 12f74de4 on 2.x
Issue #3432976: Fix ESLINT warnings using improved config rules from...
Merge request !138#3432976 Eslint [8.x-1.x] → (Merged) created by jonathan1055
Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Not currently mergeable.
Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Not currently mergeable.
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
Build Successful
Comment 10 months ago →
🇬🇧United Kingdom jonathan1055
Fixed in 2.x. Now for 8.x-1.x

🇬🇧United Kingdom jonathan1055

Starting point for 8.x-1.x

50 problems (50 errors, 0 warnings)
36 errors and 0 warnings potentially fixable with the `--fix` option.

Comment 7 months ago →
🇬🇧United Kingdom jonathan1055
The automatic patch fixed many of the errors. We are left with

13 problems (13 errors, 0 warnings)
https://git.drupalcode.org/project/scheduler/-/jobs/2433099#L35
Pipeline finished with Skipped
7 months ago
#254088
Comment 7 months ago →
System Message

jonathan1055 → committed 239efaae on 8.x-1.x
Issue #3432976 by jonathan1055: Fix ESLINT warnings using improved...
Status changed to Fixed 7 months ago4:21pm 14 August 2024
Comment 7 months ago →
🇬🇧United Kingdom jonathan1055
Eslint is now clean and green on 8.x-1.x
Merged and fixed.
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.json

Merge Requests

!138Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.json
Merged

!124Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.json
Merged

Comments & Activities

Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.json

Merge Requests

!138Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.jsonMerged

!124Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.jsonMerged

Comments & Activities

!138Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.json
Merged

!124Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.json
Merged