- Issue created by @reevo
- last update
3 months ago 36 pass, 8 fail
AmpHtmlResponseAttachmentsProcessor strips semicolons from the amphtml http_header value, resulting in a malformed HTTP header.
According to the Link spec:
The link header contains parameters, which are separated with ; and are equivalent to attributes of the
element.
Relevant code:
protected function processHtmlHeadLink(array $html_head_link) {
$attached = parent::processHtmlHeadLink($html_head_link);
if (array_key_exists('http_header', $attached)) {
// Find the amphtml link and flag it to be displayed as a HTTP header.
foreach ($attached['http_header'] as $key => $value) {
if (strpos($value[1], 'rel="amphtml"') !== FALSE) {
$new_value = str_replace(';', '', $value[1]);
$attached['http_header'][$key] = ['Link', $new_value, TRUE];
}
}
}
return $attached;
}
I'm assuming that semicolons are stripped for a reason, and this is an unintended consequence.
View a non-AMP node which has an AMP version. You should see <link rel="amphtml" href="https://example.com/some/page?amp" /> in the HTML source.
Check the HTTP response headers in your browser's dev tools. You'll see that the Link header as a value of <https://example.com/some/page?amp> rel="amphtml". This should be <https://example.com/some/page?amp>; rel="amphtml"
Modify AmpHtmlResponseAttachmentsProcessor so that it no longer strips semicolons.
Patch will follow shortly.
Active
3.0
Code