[beta6] Add missing notice component

so, you decided to keep 3 options in

    dismissible:
      type: select
      label: Dismissible?
      description: It’s possible to dismiss any notice inline.
      options:
        "": No
        core: Using dsfr
        custom: Custom

And use only one in the Twig:

<button{% if dismissible == 'core' %} onclick="const notice = this.parentNode; notice.parentNode.removeChild(notice);" {% endif %} class="fr-btn fr-btn--close" title="{{ close_title }}">{{ close_title }}</button>

It doesn't look right...

I may have understood why it is also like that in alert component:

• https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/1.0.x/templates/...
• https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/1.0.x/templates/...

• if dismissible is false: no button.
• if dismissible == "custom" : a button, without the event, so the sub-theme need to provide its own event.
• if dismissible == "core" : a button, with the onclick event from DSFR.

So, the twig snippet make sense:

  {% if dismissible %}
    {% set close_title = close_title|default('Close'|t) %}
    <button{% if dismissible == 'core' %} onclick="const alert = this.parentNode; alert.parentNode.removeChild(alert);"{% endif %} class="fr-btn fr-btn--close" title="{{ close_title }}">{{ close_title }}</button>
  {% endif %}

Maybe there is something to do in both alert and notice component to make this clearer:

Do we rename the options label?
And/or do we revamp a bit the Twig implementation?
And/or do we move some logic to button component?

I would be glad to have a talk before any implementation.

Moved to beta6 in case a breaking change is done to alert. Let's add ⚠️ to the ticket title if we do the change.

Also, closing the notice keep the component wrapper. Let's fix that.

Checked with Yassine.

Do we rename the options label?

We moved to boolean prop

And/or do we revamp a bit the Twig implementation?

Indeed, because of boolean prop

And/or do we move some logic to button component?

No, because we noticed than the onlcik event is different from alert to notice.

Do we change also alert component?

No, too risky.

Automatically closed - issue fixed for 2 weeks with no activity.