- Issue created by @alexpott
- Status changed to Needs review
about 1 year ago 1:24pm 21 March 2024 - Status changed to Needs work
about 1 year ago 1:35pm 28 March 2024 - 🇺🇸United States phenaproxima Massachusetts
This mostly makes sense to me. Just a couple of minor points but I guess beyond those I'm okay RTBCing, despite being a little uncomfortable wading into the installer.
- Status changed to Needs review
about 1 year ago 2:12pm 30 March 2024 - Status changed to RTBC
about 1 year ago 2:23pm 30 March 2024 - 🇺🇸United States phenaproxima Massachusetts
Okay, look...my questions are answered and tests are passing.
As I said, I'm not very comfortable in the installer, but as far as I can tell, this looks correct. The behavior changes are subtle, for sure, but that's because of the legacy assumptions and behavior of the installer.
Kicking this upwards - seems good to go. Hopefully another committer agrees!
- Status changed to Fixed
about 1 year ago 3:12pm 30 March 2024 - 🇬🇧United Kingdom catch
I'm not very comfortable in the installer
I don't think anyone is at this point, it's still a big mess of circular dependencies but this is one more step towards untangling it.
Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.