- Issue created by @chaitanyadessai
- Issue was unassigned.
- Status changed to Needs review
9 months ago 12:04pm 20 March 2024 - last update
9 months ago 28 pass - ๐ฎ๐ณIndia rakesh.regar Rajasthan, India
rakesh.regar โ made their first commit to this issueโs fork.
- Merge request !15Issue-3432382: \Drupal calls should be avoided in classes. โ (Open) created by rakesh.regar
- last update
9 months ago 28 pass - Status changed to Postponed: needs info
9 months ago 6:37am 21 March 2024 - ๐บ๐ธUnited States tr Cascadia
@chaitanyadessai: How is \Drupal::service('extension.list.theme') getting injected? I don't see where that $this->themeHandler is defined.
@rakesh.regar: How does your merge request differ from the patch? Have you contributed anything to this issue?
- Status changed to Needs review
9 months ago 9:52am 21 March 2024 - last update
9 months ago 28 pass - Status changed to Postponed
5 months ago 8:06am 28 July 2024 - ๐บ๐ธUnited States tr Cascadia
The code looks like this:
// @todo Searching the path is not what we want - this is how it was done // in D7, but that's not how assets should be handled in D8. $mailstyle = \Drupal::service('extension.list.theme')->getPath($theme) . '/mail.css';
I don't think we should be adding all the code to do the injection when this code is likely to go away entirely as a result of the @todo.
I'm postponing this issue pending the solution to the @todo in ๐ Add support for mail.css Active