- Issue created by @fjgarlin
- Status changed to Needs review
3 months ago 3:54pm 19 March 2024 - 🇬🇧United Kingdom jonathan1055
Looks correct. But I will run a test just to make 100% sure.
- 🇪🇸Spain fjgarlin
Thanks, I appreciate it. I will commit it tomorrow morning first thing if it's RTBCed. Or work on feedback if needed.
- 🇪🇸Spain fjgarlin
Updating credits as this was reported and investigated via slack https://drupal.slack.com/archives/CGKLP028K/p1710861552589019
- Status changed to RTBC
3 months ago 4:26pm 19 March 2024 - 🇯🇵Japan ultrabob Japan
Code makes sense and the previously failing pipeline now passes! Thanks!
- 🇬🇧United Kingdom jonathan1055
Scheduler pipeline using MR160
https://git.drupalcode.org/project/scheduler/-/pipelines/123489
The jobs end amber (but that's due to other things). The problem reported in this issue has been fixed. -
fjgarlin →
committed 322a55cc on main
Issue #3432156 by fjgarlin, jonathan1055, ultrabob, jurgenhaas, ELC:...
-
fjgarlin →
committed 322a55cc on main
- Status changed to Fixed
3 months ago 8:10am 20 March 2024 - 🇪🇸Spain fjgarlin
Thanks for confirming. I've now merged this.
@ELC created #3432265: DrupalCI fails for "phpstan (next major)" → which is a duplicate of this one, so I'm transferring the credit here as it seems like we were working in parallel and achieved the same fix.
- 🇦🇺Australia ELC
This change was merged into the main repo that normal pipelines use correct?
If I run the pipeline using this merge branch as the source, it works as expected and phpstan (next major) runs fully and correctly:
_GITLAB_TEMPLATES_REPO=issue/gitlab_templates-3432156 _GITLAB_TEMPLATES_REF=3432156-fix-referenceshttps://git.drupalcode.org/project/genpass/-/jobs/1126946
However, if I just run a pipeline normally, it still uses the wrong script includes that were fixed here. ie phpunit instead of phpstan.
https://git.drupalcode.org/project/genpass/-/jobs/1127095Am I expecting something more than should be in place right now? Is this fix not working like it should?
I checked out one of the other modules that should be passing this test too and it too is failing with the same error:
https://git.drupalcode.org/project/config_inspector/-/jobs/1127414 - 🇪🇸Spain fjgarlin
@ELC, we merged this to the "main" branch, but note that this is still not rolled out to all contrib projects.
You have two alternatives, you can set
ref: mainto get the latest fixes as they are committed (documented here https://project.pages.drupalcode.org/gitlab_templates/info/templates-ver...), or maybe just wait until we change the default reference to include this change (maybe in a week or so).You can see the differences between 1.3.1 (all contrib is here now) and 1.3.2 (will be rolled out in a week or so)
https://git.drupalcode.org/project/gitlab_templates/-/compare/1.3.1...1.... Automatically closed - issue fixed for 2 weeks with no activity.
