Contrib.social

Revert change to bool variable values in JS

Open on Drupal.org →
Created on 19 March 2024, 9 months ago
Updated 18 April 2024, 8 months ago

Problem/Motivation

PHPCS fixes changed false and true value in JS to FALSE and TRUE respectively: https://git.drupalcode.org/project/epub_reader_framework/-/commit/3b6a1600670cb8e0b50e0add27421a012dee5ae4

This leads to an error in browser console:

Uncaught ReferenceError: FALSE is not defined
    <anonymous> https://localhost:8081/modules/contrib/epub_reader_framework/assets/js/history-api-set-initial-state.js?v=10.1.6:5
    <anonymous> https://localhost:8081/modules/contrib/epub_reader_framework/assets/js/history-api-set-initial-state.js?v=10.1.6:31

Proposed resolution

Revert the change to the JS bools.

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

joshhytr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024