- Issue created by @kulmjens
- Status changed to Needs review
11 months ago 11:40am 19 March 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
drunken monkey → made their first commit to this issue’s fork.
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks a lot for the suggestion, makes sense!
However, it seems Core uses the spelling “read-only” (with hyphen) in the vast majority of cases, so we should go with that, too. I also updated the existing strings (one of them, unfortunately, user-facing).Then, I think it makes sense to also add a note to the progress bar, and to hide the “Cron batch size” row (since, in fact, nothing will be indexed during cron runs).
I also moved the new row way up, right beneath “Status”.Finally, you made me realize that the CSS classes we’re using in those tables (
ok
/warning
/error
) are actually ignored by at least the Claro default admin theme. I’d guess they were probably used by Seven, which is why we added them, but we failed to notice that Claro changed that. The new classes are thecolor-*
classes. So, I updated also all existing rows that use either thewarning
orerror
class to also have the correspondingcolor-*
class. (I kept the existing classes, too, in case someone’s custom admin theme relies on those. Not quite sure about that, though.)
In any case, the index being read-only might be something we want to warn people about so they do notice it, but it’s definitely not an error (generally speaking, that is), so I downgraded the new message accordingly.Please tell me what you think about these changes!
I realize that some are a bit out of scope, but I think it’s OK to make this a general “lets improve the ’View’ tabs a bit” issue. - 🇩🇪Germany kulmjens
Thank you very much for your changes!
For each of your points I give a thumbs-up.
I applied the changes, tested them a bit and they work like a charm. - Status changed to Fixed
10 months ago 2:01pm 29 March 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
Great to hear, thanks for reporting back!
Merged. Thanks again! -
drunken monkey →
committed 7838daa6 on 8.x-1.x authored by
kulmjens →
Issue #3432090 by kulmjens, drunken monkey: Added read-only hint and...
-
drunken monkey →
committed 7838daa6 on 8.x-1.x authored by
kulmjens →
Automatically closed - issue fixed for 2 weeks with no activity.