CommandExecutor should not use fromShellCommandline

Created on 16 March 2024, over 1 year ago

Updated 10 April 2024, over 1 year ago

Problem/Motivation

In \Drupal\automatic_updates\CommandExecutor::create we are just imploding the arguments and then
using \Symfony\Component\Process\Process::fromShellCommandline

Steps to reproduce

Proposed resolution

We should use escapeshellarg when creating the arguments and not use fromShellCommandline

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

3.0

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.

Merge Requests

!1035CommandExecutor should not use fromShellCommandline
Open
🇺🇸United States tedbow
updated over 1 year ago

Comments & Activities

Issue created by @tedbow
Comment over 1 year ago →
🇺🇸United States tedbow Ithaca, NY, USA
Merge request !1035Issue #3429248 don't use fromShellCommandline → (Open) created by tedbow
First commit to issue fork.
Pipeline finished with Canceled
over 1 year ago
Total: 253s
#143203
Pipeline finished with Canceled
over 1 year ago
Total: 101s
#143205
Pipeline finished with Failed
over 1 year ago
Total: 1254s
#143206
Pipeline finished with Success
6 months ago
Total: 556s
#497726

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024