Remove rule Drupal.Commenting.FunctionComment.InvalidReturnNotVoid

/** * Some array returning function. * * @return array * Some array. */ function returnSomeArray(): array { do_something_with_a_callback(function () { if ($some_condition) { // Early return. return; } // Do work. }); return []; }

Comments & Activities

Issue created by @kingdutch

Comment about 1 year ago →

System Message

klausi → authored 24bad887 on 8.3.x

fix(FunctionComment): Ignore return statements in closures (#3427690)

Status changed to Fixed about 1 year ago8:36am 13 April 2024
Comment about 1 year ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Thanks for reporting!

We don't need to throw out this check, we can modernize if from the upstream Squiz standard which already implemented closure support.

It was a bit of a riddle to figure out, but thanks to our test cases I got it working: https://github.com/pfrenssen/coder/pull/223

I had to disable one test that did even a bit more semantics checking, which should really be done by phpstan.

And merged!
Comment 12 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Remove rule Drupal.Commenting.FunctionComment.InvalidReturnNotVoid

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities