Disable DrupalCI

Created on 12 March 2024, 9 months ago
Updated 16 April 2024, 8 months ago

Problem/Motivation

Now that we have GitLab CI working, it's time to turn of DrupalCI.

Steps to reproduce

N/A

Proposed resolution

  1. Disable the CI tasks in the project settings on drupal.org.
  2. Delete the drupalci.yml file from the repository.
  3. Do we still need scripts/commit-code-check.yml?
  4. For PHPStan, edit phpstan.neon.dist, and add /web/ to the path. Remove the phpstan before script.
  5. For CSpell, delete .cspell.json, rename dictionary.txt to .cspell-project-words.txt. Remove cspell before script.
  6. Clean up code comments referencing DrupalCI
📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇪Ireland lostcarpark

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @lostcarpark
  • 🇺🇸United States chrisfromredfin Portland, Maine

    There are also mentions of DrupalCI in comments that could be cleaned up:

    tests/src/FunctionalJavascript/ProjectBrowserUiTest.php
    131:    // failing on ~2% of DrupalCI test runs. It is not entirely clear why this
    133:    // Svelte app has occasional initialization problems on DrupalCI that are
    
    tests/src/FunctionalJavascript/ProjectBrowserUiTestJsonApi.php
    123:    // failing on ~2% of DrupalCI test runs. It is not entirely clear why this
    125:    // Svelte app has occasional initialization problems on DrupalCI that are
    
    tests/src/FunctionalJavascript/ProjectBrowserUiTestTrait.php
    37:   *   needs to be set to TRUE for calls that intermittently fail on DrupalCI.
    182:   * In ~1% of DrupalCI tests, Svelte will not initialize. Since this difficulty
    183:   * initializing is specific to DrupalCI and a refresh consistently fixes it,
  • 🇺🇸United States drumm NY, US

    I see no reason to wait for removing DrupalCI testing. I recommend removing it as soon as GitLab CI is passing with allowed failures in linting, and looks like it is even passing linting now. I'd say it is more than ready.

  • Merge request !450Changes for removal of DrupalCI. → (Merged) created by lostcarpark
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    Waiting for branch to pass
  • Status changed to Needs review 9 months ago
  • 🇮🇪Ireland lostcarpark

    Changes made for GitLab to run without DrupalCI.
    FunctionalJavascript test failed, but seems to be unrelated to this change (reporting about click that would land outside intended element).

  • Status changed to Needs work 9 months ago
  • 🇺🇸United States chrisfromredfin Portland, Maine
  • Status changed to Needs review 9 months ago
  • 🇮🇪Ireland lostcarpark

    Explained phpstan path change. Seeing back to needs review.

  • Pipeline finished with Failed
    9 months ago
    Total: 64201s
    #129982
  • Pipeline finished with Skipped
    9 months ago
    #130687
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    Waiting for branch to pass
  • Status changed to Fixed 9 months ago
  • 🇺🇸United States chrisfromredfin Portland, Maine

    Thank you, James! (And the Association thanks you, vicariously!)

  • 🇺🇸United States drumm NY, US

    Be sure to click “delete all DrupalCI testing schedules” at https://www.drupal.org/node/1143512/qa

  • 🇺🇸United States chrisfromredfin Portland, Maine

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024