- Issue created by @theMusician
- πΊπΈUnited States theMusician
Forgot to use the create issue fork for this fix.
https://git.drupalcode.org/project/ableplayer/-/jobs/1077005 - Status changed to Fixed
about 1 year ago 5:56pm 15 March 2024 - First commit to issue fork.
- π¬π§United Kingdom jonathan1055
Hi,
Following up our conversion on Slack I'd like to use this issue to test some improvements to gitlab_templates cspell job.
See #3426136: Execute CSPELL in project root folder and make fixing words easier βWe need projects that have already fixed their spelling errors, to make sure the new changes do not cause any regression.
- πΊπΈUnited States theMusician
@jonathan1055 reviewing the latest pipeline build the changes look good. CSPELL passes.
- π¬π§United Kingdom jonathan1055
The initial commit shows that when using the modified gitlab process the cspell job still passes green without any modifications needed.
https://git.drupalcode.org/issue/ableplayer-3427424/-/pipelines/122353However, the input can be simplified by not needing quotes around each separate word in _CSPELL_WORDS and _CSPELL_IGNORE_PATHS. It also shows that some words no longer need to be listed. The module name is automatically added, and other words are included in the extra dictionaries being used.
https://git.drupalcode.org/project/ableplayer/-/merge_requests/37/diffs
You can leave this MR open, and when the gitlab templates change has been committed and the 'default-ref' tag moved to include it, you can commit this. It will need the temporary change to 'project' and 'ref' to be removed. I can return here to test it once the change is rolled out to all users.
Thanks for letting me use your project for this testing.
- πΊπΈUnited States theMusician
The automatic addition of the project name to the job is smart.
That will smooth things out for a lot of projects I bet. Congratulations on simplifying the quote pattern.
Thanks for your help originally with this as well.
- Status changed to RTBC
about 1 year ago 1:55pm 28 March 2024 - π¬π§United Kingdom jonathan1055
#3426136: Execute CSPELL in project root folder and make fixing words easier β has been committed.
Also the gitlab_templates
default-ref
tag has been updated to include this change for all contrib by default. Hence I have reverted the temporary change here.The updated CSPELL doc page is https://project.pages.drupalcode.org/gitlab_templates/jobs/cspell/
I have set this to RTBC because you are welcome to merge in the simplification here in MR37. (The phpunit job failure is separate)
- Status changed to Fixed
3 months ago 6:06pm 24 January 2025 - π¬π§United Kingdom jonathan1055
I see that you did not actually commit the simplified cspell list from the MR.
- 02ded7fb committed on 3.x
Issue #3427424: Resolve cspell errors found by gitlab pipeline and align...
- 02ded7fb committed on 3.x
- πΊπΈUnited States theMusician
Hi,
The simplified version is now in place. https://git.drupalcode.org/project/ableplayer/-/blob/3.x/.gitlab-ci.yml#L61
Thank you
- π¬π§United Kingdom jonathan1055
There are still words that do not need to be specified. I have re-based MR37 so it is mergeable now.
-
themusician β
committed 912f32b1 on 3.x authored by
jonathan1055 β
Issue #3427424 by jonathan1055: Resolve cspell errors found by gitlab...
-
themusician β
committed 912f32b1 on 3.x authored by
jonathan1055 β
- πΊπΈUnited States theMusician
Thank you again @jonathan1055 for sticking with this one. I had not realized that the dictionaries CSPELL pulls from now are multiple, https://git.drupalcode.org/project/drupal/-/blob/11.1.2/core/.cspell.jso....
Merged and credit provided.
If we can help in the future via this project, please reach out.
- π¬π§United Kingdom jonathan1055
I'm pleased to help.
The link you gave is to the dictionaries that Core uses. But for contrib, Gitlab Templates expands that list to use a lot more good dictionaries which contrib projects can make use of, to avoid too many custom additions.
- πΊπΈUnited States theMusician
Thank you for the follow-up. I appreciate the extra information.