- Issue created by @theMusician
- 🇺🇸United States theMusician
Forgot to use the create issue fork for this fix.
https://git.drupalcode.org/project/ableplayer/-/jobs/1077005 - Status changed to Fixed
3 months ago 5:56pm 15 March 2024 - First commit to issue fork.
- 🇬🇧United Kingdom jonathan1055
Hi,
Following up our conversion on Slack I'd like to use this issue to test some improvements to gitlab_templates cspell job.
See #3426136: Execute CSPELL in project root folder and make fixing words easier →We need projects that have already fixed their spelling errors, to make sure the new changes do not cause any regression.
- 🇺🇸United States theMusician
@jonathan1055 reviewing the latest pipeline build the changes look good. CSPELL passes.
- 🇬🇧United Kingdom jonathan1055
The initial commit shows that when using the modified gitlab process the cspell job still passes green without any modifications needed.
https://git.drupalcode.org/issue/ableplayer-3427424/-/pipelines/122353However, the input can be simplified by not needing quotes around each separate word in _CSPELL_WORDS and _CSPELL_IGNORE_PATHS. It also shows that some words no longer need to be listed. The module name is automatically added, and other words are included in the extra dictionaries being used.
https://git.drupalcode.org/project/ableplayer/-/merge_requests/37/diffs
You can leave this MR open, and when the gitlab templates change has been committed and the 'default-ref' tag moved to include it, you can commit this. It will need the temporary change to 'project' and 'ref' to be removed. I can return here to test it once the change is rolled out to all users.
Thanks for letting me use your project for this testing.
- 🇺🇸United States theMusician
The automatic addition of the project name to the job is smart.
That will smooth things out for a lot of projects I bet. Congratulations on simplifying the quote pattern.
Thanks for your help originally with this as well.
- Status changed to RTBC
3 months ago 1:55pm 28 March 2024 - 🇬🇧United Kingdom jonathan1055
#3426136: Execute CSPELL in project root folder and make fixing words easier → has been committed.
Also the gitlab_templates
default-reftag has been updated to include this change for all contrib by default. Hence I have reverted the temporary change here.The updated CSPELL doc page is https://project.pages.drupalcode.org/gitlab_templates/jobs/cspell/
I have set this to RTBC because you are welcome to merge in the simplification here in MR37. (The phpunit job failure is separate)