Fix phpstan warnings

Created on 12 March 2024, 4 months ago

Updated 15 June 2024, 13 days ago

At levels 6 and above, the module causes many PHPstan warnings. Fix them to we can focus on more important issues.

Install a Drupal 10.3 site
Install the module
Install the core_dev and the upgrade_status module, which will set up PHPstan
From the project root: ./vendor/bin/phpstan analyse -l9 web/modules/contrib/url_replace_filter

Apply the required fixes: most of them are just PHPdocs to add, but also include the params and return types.

Pass PHPstan level 9.

None.

None.

None.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France fgm Paris, France

Live updates comments and jobs are added and updated live.

Merge Requests

Issue created by @fgm
Status changed to Needs work 4 months ago11:17am 12 March 2024
Comment 4 months ago →
🇫🇷France fgm Paris, France
Here is a starter patch to complete.
Comment 13 days ago →
🇫🇷France fgm Paris, France
Merge request !3Resolve #3427325 "Fix phpstan warnings" → (Merged) created by fgm
Comment 13 days ago →
System Message

fgm → committed a94fea0f on 8.x-1.x
Resolve #3427325 "Fix phpstan warnings up level 8 and some more"
Status changed to Fixed 13 days ago8:19am 15 June 2024
Comment 13 days ago →
🇫🇷France fgm Paris, France
Fixed in today's HEAD.

Production build 0.69.0 2024