D10 settings are not getting attached to JS when alerts are disabled

Created on 11 March 2024, 10 months ago

Problem/Motivation

D10 settings are not getting attached to JS when all alerts are disabled.
Error is: Uncaught TypeError: Cannot read properties of undefined (reading 'workaround_needed')

Steps to reproduce

I have several disabled site alerts.
When I create a landing page and set it to unpublished on the view page I see this error in the console:
Uncaught TypeError: Cannot read properties of undefined (reading 'workaround_needed')

Proposed resolution

Add a check in site_alert.js to ensure that drupalSettings exists and that drupalSettings.siteAlert exits before attempting to access properties.

🐛 Bug report

Status

Needs review

Version

1.3

Component

Code

Created by

🇺🇸United States wstocker

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @wstocker
Status changed to Needs review 10 months ago5:51pm 11 March 2024
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
73 pass
Comment 10 months ago →
🇺🇸United States wstocker
Adding patch file to fix this issue.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024