- Issue created by @plopesc
- Assigned to m4olivei
- 🇨🇦Canada m4olivei Grimsby, ON
I'm going to work on this, this afternoon and see how far I get.
- Merge request !209Closes #3426576 Add tests for user navigation block → (Merged) created by m4olivei
- Issue was unassigned.
- Status changed to Needs review
8 months ago 9:31pm 28 March 2024 - 🇨🇦Canada m4olivei Grimsby, ON
This is ready for review!
Unlike for SystemMenuNavigationBlockTest, I ended up writing a functional test as well b/c the lazy builder in
\Drupal\navigation\Plugin\NavigationBlock\UserNavigationBlockmeans most of the interesting bits to test need a full rendering. - Status changed to Needs work
8 months ago 11:41pm 28 March 2024 - 🇪🇸Spain plopesc Valladolid
Code looks great!
Just a added a minor code suggestion.
I would encourage to add more specific assertions to ensure cache is behaving as expected, see comment in MR.
Thank you!
- 🇪🇸Spain plopesc Valladolid
Took the freedom to create 🐛 Navigation Bar implementation makes all pages uncacheable Active to handle the caching issues and their possible ramifications.
- Status changed to Needs review
8 months ago 1:35pm 1 April 2024 - 🇨🇦Canada m4olivei Grimsby, ON
With the fixes from 🐛 Navigation Bar implementation makes all pages uncacheable Active , we should be all set here.
- Status changed to RTBC
8 months ago 1:42pm 1 April 2024 -
plopesc →
committed 466c4744 on 1.x authored by
m4olivei →
Closes #3426576 Add tests for user navigation block
-
plopesc →
committed 466c4744 on 1.x authored by
m4olivei →
- Status changed to Fixed
8 months ago 1:48pm 1 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.