Action for adding an adjustment to order

There is not an action for this, but if you are able to contribute it I would be happy to review.

I've implemented a new action for this, though I had originally built it against 2.1.x, so I had to leave out some features to make it compatible with 1.0.x.
I will probably need advice on how I should wrangle git to create forward ports to the 2.1.x branch so I can put the extra features back.

@sundancenaturalist the best way to do things like this, is to develop against the latest release, 2.1.x in this case. Once finalized, you can then back port to previous release and, if necessary, be selective if some stuff wouldn't be supported there.

In a case where you would want to propose an enhancement without waiting for the latest release to accept the change before back porting, you would have to create a second branch in the fork and create another MR from there. So, you would then have one MR from 1.0.x in the fork to 1.0.x in the project repo, and another one from 2.1.x in the fork to 2.1.x in the project repo. But then, both would have to be reviewed and probably still being worked on, which is extra effort that if that could be avoided, everybody would appreciate.

starlight-sparkle → changed the visibility of the branch 3426536- to hidden.

Thank you so much for this I'll try to take a look, in the meantime there are some minor coding standards https://git.drupalcode.org/issue/eca_commerce-3426536/-/jobs/3984100

Feel free to wait to address those until you get a first pass review.

As a side note, this implementation also includes a Trait which can be reused to support currencies other than USD in the existing "Change Price in Cart" action.

what status should this issue be in now? "Needs review"?

Yes! Assuming you think it's ready.

nicxvan → changed the visibility of the branch 3426536-adjustment-action to hidden.

Thank you so much for this contribution!

I think I'm going to mark 1.x as not recommended and only merge this into 2.x

I'll cut a release later today I think.

Automatically closed - issue fixed for 2 weeks with no activity.