- Issue created by @alexrayu
- Status changed to Needs review
10 months ago 3:02pm 7 March 2024 - Status changed to Needs work
10 months ago 2:53pm 10 March 2024 - 🇫🇷France MacSim
Interesting feature. Thanks for your contribution.
However I think we should either set it per entity type or per bundle instead of setting it globally.
That would give a more granular way to choose which content really is important to index - Merge request !17Issue #3426410: Make entity hooks configurable in config → (Merged) created by MacSim
- Status changed to Needs review
9 months ago 3:43pm 13 March 2024 - 🇫🇷France MacSim
Can you please check if the feature is fine with the patch https://git.drupalcode.org/project/index_now/-/merge_requests/17.diff ?
- Status changed to Needs work
9 months ago 11:47am 14 March 2024 - Status changed to Needs review
9 months ago 1:10pm 14 March 2024 -
MacSim →
committed 0a358ede on 3.1.x
Issue #3426410: Make entity hooks configurable in config
-
MacSim →
committed 0a358ede on 3.1.x
- Status changed to Fixed
9 months ago 3:07pm 14 March 2024 - 🇩🇪Germany axroth Stuttgart
@MacSim
thanks for the new release!
Can't we have both features? - Status changed to Fixed
9 months ago 8:48am 15 March 2024 - Status changed to Fixed
9 months ago 8:59am 15 March 2024 - 🇫🇷France MacSim
Hmm sorry I didn't reloaded the page and didn't saw your comment @axroth
What do you mean by "both features?" "per entity type" / "per bundle" ?What I did here based on what was provided by @alexrayu in #2 is a "per entity type hooks config"
I need to upgrade Index Now Commerce → to do the same thing.We could open a new feature request for a "per bundle hooks config" but it would be more complex especially on the test level.
The feature request has only been merged on 3.1.x branch.
- 🇩🇪Germany axroth Stuttgart
> What do you mean by "both features?" "per entity type" / "per bundle" ?
My mistake. I could have seen it in the form. Thanks for having this hook-based feature in this release.
- Status changed to Fixed
9 months ago 9:47am 15 March 2024