Contrib.social

Drop isMethodCacheable check on query alters

Open on Drupal.org →
Created on 7 March 2024, 10 months ago
Updated 26 March 2024, 9 months ago

Follow-up from 📌 Make POST requests render cacheable Needs work .

Essentially it turned out that adding these checks didn't do anything to begin with On POST requests: We would never get a cache hit, nor set the cache. Now we can get a cache hit, which doesn't run said code or still do not set anything on a cache miss. So worst case scenario the code runs but has no effect. The upside is that if we remove the check and we somehow do end up supporting cache sets on POST (fat chance in hell) that our code won't be insecure. If we leave the check, it will be.

📌 Task
Status

Fixed

Version

3.3

Component

Code

Created by

🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024