Improve the standard performance login test

Created on 7 March 2024, 4 months ago

Problem/Motivation

📌 Make POST requests render cacheable Needs work didn't show as much of a performance improvement as you'd expect in StandardPerformanceTest, because the standard profile with no content doesn't have much to render.

Steps to reproduce

Proposed resolution

Couple of options:

1. Move login testing to umami which already has some content. This would require enabling the login block in the Umami test (but we also do that in the standard test, it's just not 'pure' Umami to have it enabled).

2. Add ten nodes instead of one to the standard front page so that more rendering happens.

We could also add a test that submits the wrong password for a user so that the login block fails validation, this will cause the entire page to be rendered without a redirect - and is quite important for user-facing performance that this comes back quickly, may affect 'interation to next paint'/INP etc.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component
PHPUnit  →

Last updated about 12 hours ago

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
  • Performance

    It affects performance. It is often combined with the Needs profiling tag.

Sign in to follow issues

Comments & Activities

  • Issue created by @catch
  • 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

    If we start moving more tests to the Umami tests, we might lose track of what the performance of a "clean" Drupal is. Would it make sense to have the same tests run where one is using "demo_umami" and the other is using "standard"? Then with any change to core we can see how it improves performance on a very minimalistic site vs a very realistic one.

  • 🇬🇧United Kingdom catch

    Given the install profile is a property on the test class it'd probably be easier to duplicate the coverage (or add an extra trait with the test methods), but we can definitely do that and agree it's good to test both cases at least for things that are different. Reminds me we need to add query/cache assertions to all the Umami performance tests now that counts are stabilised etc.

  • 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

    Reminds me we need to add query/cache assertions to all the Umami performance tests now that counts are stabilised etc.

    I think I did the query part already for those tests that were previously checking query counts.

  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    👀

Production build 0.69.0 2024