Contrib.social

Remove Drupal 6 migration plugins

Open on Drupal.org →
Created on 6 March 2024, 4 months ago
Updated 12 March 2024, 4 months ago

Problem/Motivation

Drupal 6 migration plugins are included by default by migrate_drupal.

This causes errors in some migrate logic and is a performance hit in general.

Because AMA is now open source, it'll ideally work consistently between ama:* and migrate:* Drush commands and logic. AMA manages migration clusters, and migrate manages individual migrations. We should ensure all migration logic runs clean, whether in AMA or elsewhere.

Example errors:

 [error]  Could not retrieve source count from d6_vocabulary_field: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'shoah.vocabulary' doesn't exist: SELECT COUNT(*) AS "expression"
FROM
(SELECT 1 AS "expression"
FROM
"vocabulary" "v") "subquery"; Array
(
)
 
 [error]  Could not retrieve source count from d6_vocabulary_field: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'shoah.vocabulary' doesn't exist: SELECT COUNT(*) AS "expression"
FROM
(SELECT 1 AS "expression"
FROM
"vocabulary" "v") "subquery"; Array
(
)
 
 [error]  Could not retrieve source count from d6_vocabulary_field_instance: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'shoah.vocabulary' doesn't exist: SELECT COUNT(*) AS "expression"
FROM
(SELECT 1 AS "expression"
FROM
"vocabulary" "v"
INNER JOIN "vocabulary_node_types" "nt" ON "v"."vid" = "nt"."vid") "subquery"; Array
(
)

Steps to reproduce

Run "drush ms" and observe database errors due to missing D6 tables.

Proposed resolution

Alter migration plugins to remove those with tag "Drupal 6".

Remaining tasks

Implement resolution.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

✨ Feature request
Status

Needs work

Version

1.9

Component

Code

Created by

🇺🇸United States jienckebd

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jienckebd
  • Comment 4 months ago →
    🇺🇸United States jienckebd
  • Comment 4 months ago →
    🇺🇸United States jienckebd
  • Merge request !553425915: Remove Drupal 6 migration plugins. → (Open) created by jienckebd
  • Pipeline finished with Failed
    4 months ago
    Total: 677s
    #112365
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    Run "drush ms" and observe database errors due to missing D6 tables.

    This is the reason. Just use drush ama:* commands for any broad operations, and only use drush migrate:* commands for specific operations on individual migration plugins after you've surfaced/found them using drush ama:* commands.

    If you do that, you'll never run into this.

    That being said:

    Alter migration plugins to remove those with tag "Drupal 6".

    is very pragmatic! 😄 I like it 😊

    Review

    But the current is far too cowboy-esque 🤠 It removes all migrations with the Drupal 6 tag … but quite a few that have that tag also have the Drupal 7 tag 😅

    So this is removing Drupal 7 migrations too! The tests make that obvious.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024