Unify preSave and postSave logic for memberships.

Created on 5 March 2024, 11 months ago

Problem/Motivation

Currently, we have code in GroupRelationship::postSave() that is unique to memberships. We shouldn't privilege one plugin over the others. We should move this to hook_ENTITY_TYPE_update and hook_ENTITY_TYPE_insert.

While we're at it, we introduced some safety checks on GroupMembershipTrait in #3132084: Add/Remove group role for a user programmatically → and should move that to hook_ENTITY_TYPE_presave here so that they run even if the API (addRole) is bypassed.

📌 Task

Status

Active

Version

3.3

Component

Code

Created by

🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

Live updates comments and jobs are added and updated live.

Group 3.3.0

Comments & Activities

Issue created by @kristiaanvandeneynde
Comment 3 months ago →
🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
The preSave logic has been moved to constraints that are checked in GroupMembershipTrait. This takes it out of GroupRelationship code, even though the constraints technically apply to the whole entity type, they have plugin ID checks inside them.

See: 📌 Disallow the programmatic assignment of insider/outsider roles to members Active

So all that's left here is to move the postSave code. This could probably be moved to the GroupMembershipTrait also.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024