H5PDefaultFormatter should add user cache context.

I have opened the MR https://git.drupalcode.org/project/h5p/-/merge_requests/18. Also attaching the fix as a patch. Please review.

This makes sense, but it should only add this cache context if 'save content state' is enabled I think - then when it's not enabled, there would still be a higher cache hit rate.

Hello @catch, thank you for checking this. I agree with your opinion. I have pushed new changes to the MR and also added a new patch to this comment. Please review.

Patch #5 no longer applies to 2.0.x-dev so created a new patch file off the latest dev code. @id.aleks - please take a look and make sure I didn't miss anything.

I have used similar steps to the ones you suggest for testing, and in my tests can confirm that the patch resolves the issue of showing a different user with the same role's cached progress. I also confirmed that the additional user context is only added when the Save content state option option is enabled.

@illeace The patch looks good to me. Could you also update the MR according to your changes?

You bet. I'll work on that now.

@id.aleks I've rebased the issue branch off of 2.0.x from origin and it shows as mergeable now. I've also checked out the issue branch, rolled back the code before you commits and reproduced the issue. Then I pulled in your commits and retested, confirming the issue no longer occurs. I'm not sure if it's kosher, but I'm going to go ahead and mark this RTBC, but I could get somebody else to test if desired.

Great, thank you! Merged and marked as fixed.

Automatically closed - issue fixed for 2 weeks with no activity.