Fix instanceof check that fails on old browsers using the dialog polyfill

Created on 1 March 2024, 10 months ago

Updated 15 March 2024, 9 months ago

The MultiselectDropdown class has a check !(dialog instanceof HTMLDialogElement) which fails on old browsers even when the polyfill is loaded.

This check is extra specific and can be removed in favor of just asserting the dialog element exists, regardless of its type.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States benabaird

Live updates comments and jobs are added and updated live.

Merge Requests

Issue created by @benabaird
Merge request !1Polyfill fix. → (Merged) created by benabaird
Pipeline finished with Skipped
10 months ago
#107553
Comment 10 months ago →
System Message

benabaird → committed 245b3ba2 on 1.0.x
Issue #3424787: Fix instanceof check that fails on old browsers using...
Status changed to Fixed 10 months ago3:04am 1 March 2024
Comment 10 months ago →
🇺🇸United States benabaird
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024