Fix PHP CS issues and update for D10 compatibility.

Created on 29 February 2024, 7 months ago

Updated 30 March 2024, 6 months ago

Problem/Motivation

Code within version 4.x fails to pass PHP coding standards.

Steps to reproduce

Run PHP CS on the 8.x-4.x branch of best reply:

FILE: BestReplyConfigurationForm.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\ConfigFormBase.
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: BestReplyController.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------
   9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\comment\CommentInterface.
 181 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------


FILE: bestreply.module
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Proposed resolution

Update the affected files, so that they can pass PHP coding standards.

Remaining tasks

Create a branch containing the specific PHP coding standard fixes as well as D10 update for compatibility.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

📌 Task

Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States kevgrob

Live updates comments and jobs are added and updated live.

Merge Requests

!5Fix PHP CS issues and update for D10 compatibility.
Merged
🇺🇸United States kevgrob
updated 6 months ago

Comments & Activities

Issue created by @kevgrob
Comment 7 months ago →
🇺🇸United States kevgrob
Merge request !5Resolve #3424760 "Fix php cs" → (Merged) created by kevgrob
Comment 6 months ago →
System Message

kevgrob → committed b7d3b601 on 8.x-4.x
Resolve #3424760 "Fix php cs"
Status changed to Fixed 6 months ago11:31pm 29 March 2024
Comment 6 months ago →
🇺🇸United States kevgrob
Status changed to Fixed 6 months ago12:16am 30 March 2024
Comment 6 months ago →
🇺🇸United States kevgrob

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024