D10: Update recommendation for Webform Migrate (drupal/webform_migrate)

Created on 29 February 2024, 9 months ago
Updated 4 March 2024, 9 months ago

Problem/Motivation

Project URL: https://www.drupal.org/project/webform_migrate β†’

The webform_migrate module was supported in a D9 recommendation that is not yet ported to D10:

  1. The project now has a new 2.0.x branch.
  2. 6 of the patches have been merged and closed.
  3. 4 of the patches have not been merged and still apply clean on the new 2.0.x branch.
  4. 1 of the patches needs to be rerolled on the 2.0.x branch. This patch also needs 5 or 6 changes based on the latest feedback from maintainer. ✨ Webform Validation migration support from D7 to D9 Needs review

D9 recommendation:

        {
            "package": "drupal/webform_migrate",
            "constraint": "1.2",
            "patches": {
                "Issue #3182468: Time elements migrated as 'time' instead of 'webform_time'": "https://git.drupalcode.org/project/webform_migrate/commit/af2708e.diff",
                "Issue #3164697: migrations/d7 directory": "https://git.drupalcode.org/project/webform_migrate/-/commit/732400e762e50d2aee997d6e331c598024df968f.diff",
                "Issue #3170195: Migrate conditions of type \"contains\"": "https://www.drupal.org/files/issues/2020-09-21/webform_migrate-support_contains-3170195-3.patch",
                "Issue #3172154: Fix source plugin's undefined index issues, schema issues and unnecessary trailing whitespaces and empty lines": "https://www.drupal.org/files/issues/2021-01-15/webform_migrate-fix_source_plugin_and_schema_issues-3172154-10.patch",
                "Issue #3172161: Fix the migration of option selects with groups": "https://www.drupal.org/files/issues/2020-09-21/webform_migrate-option_group-3172161-2.patch",
                "Issue #3172162: Adjust (the correct) value for webform submission's URI": "https://www.drupal.org/files/issues/2020-09-21/webform_migrate-submission_uri-3172162-2.patch",
                "Issue #3172176: D7 Fix the migration of nested values, multi-value field types (e.g. checkboxes) and handle 'grid' type submission values": "https://www.drupal.org/files/issues/2020-09-21/webform_migrate-nested_multi_value_submission_migration-3172176-2.patch",
                "Issue #3172417: d7_webform_submissions migrates uid without using migration lookup": "https://www.drupal.org/files/issues/2020-10-21/webform_migrate-use_migration_lookup_for_submission_owners-3172417-5.patch",
                "Issue #3172139: Enable project testing, and add a kernel test and a source database and files fixture": "https://www.drupal.org/files/issues/2021-04-01/webform_migrate-kernel_test-3172139-19.diff",
                "Issue #3172473: d7_webform_submissions should have required dependency on d7_file migration IF there are webform submission-uploaded files": "https://www.drupal.org/files/issues/2022-07-06/webform_migrate-submission_migration_file_dependency-3172473-6.patch",
                "Issue #3260773: Webform_validation migration support from D7 to d9, 8.x-1.2 supported.": "https://www.drupal.org/files/issues/2022-02-15/webform_migrate-webform_validation_migration-1.2-3260773-7.patch"
            },
            "replaces": {
                "name": "webform"
            },
            "install": [
                "webform_migrate"
            ],
            "vetted": true
        },

Steps to reproduce

N/A

Proposed resolution

Take snippet from D9 recommendation, update for Drupal 10 compatibility, add to D10 curated.json

Remaining tasks

  1. Reroll the remaining patch on the 2.0.x branch. ✨ Webform Validation migration support from D7 to D9 Needs review
  2. Address pending feedback from project maintainer.
  3. Test on real clients -- high regression potential given scope of patch.
  4. MR to recommendations-10 branch with updated curated.json to include webform_migrate.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

πŸ“Œ Task
Status

Needs work

Version

1.9

Component

Recommendations β€” Drupal 10

Created by

πŸ‡ΊπŸ‡ΈUnited States jienckebd

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024