Contrib.social

Improve methodology for handling Google watermark

Open on Drupal.org →
Created on 28 February 2024, about 1 year ago
Updated 13 March 2024, about 1 year ago

Problem/motivation

The 4.x branch of this module uses a different methodology to suppress the Google-provided watermark, using a display:none in https://git.drupalcode.org/project/google_cse/-/blob/4.x/css/no_watermar..., where the 3.x version used JS to render the watermark: https://git.drupalcode.org/project/google_cse/-/blob/8.x-3.x/js/google_c...

The result is that in the 4.x branch, whether or not the watermark is visible, a background attribute is added. This appears to slightly alter the position of the elements inside the form.

Proposed resolution

in addition to setting display:none to suppress the watermark, set .google-cse input[type="search"] background: unset !important; (the !important being necessary to override the inline style added by Google).

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.
📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States mark_fullmer Tucson

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024