Error in CollectPathsToExcludeEvent.php -> must be string, bool given

@rehm, fixed the issue created Patch . please review it.

@rehm did you install the module via Composer? Can provide your composer lock file? I wondering if there is some problem with your version of php-tuf/composer-stager for some reason.

@abhishek_gupta1 thanks for the patch but first we need to figure why there is boolean instead of string provide instead of just throwing an exception.

I wondering if the problem comes from \Drupal\package_manager\PathExcluder\SiteFilesExcluder::excludeSiteFiles

 if ($this->fileSystem->isAbsolutePath($path)) {
          $event->addPathsRelativeToProjectRoot([realpath($path)]);
        }

realpath() could return a false

@rehm this could be caused by your private or public file settings point to path that does not exist. These are usually set in setting.php . $settings['file_public_path'] or $settings['file_private_path'] you can check the current values at admin/config/media/file-system

I set

$settings['file_private_path'] = '/not/here';

and it caused the same error you experienced.

@rehm can you check these paths and see if they point to real paths?

One request (we should use the file_system service's realpath() function), otherwise RTBC from me. We might want to also add an @see to the test, or maybe a more expansive comment, to explain what's going on.

@phenaproxima back to you

Looks pretty good to me!

🎉

Automatically closed - issue fixed for 2 weeks with no activity.