- Issue created by @daletrexel
- Merge request !43Issue #3423648: Unserialize() 'data' only when not null. β (Open) created by daletrexel
- last update
9 months ago 1 pass - πΊπΈUnited States daletrexel Minnesota, USA
Merge request submitted.
Noting related issues:
π Passing null to parameter #1 ($data) of type string to unserialize() is deprecated Fixed comment #29 π Passing null to parameter #1 ($data) of type string to unserialize() is deprecated Fixed by @drupalninja99 β who should also get credit for this issue. Their patch β is similar, but based on the example I followed, we probably don't need the!empty($values['data'])
check.β¨ There is no display available. Please select another view or change the field settings. Needs review Also references the unserialize on null deprecation error. Possibly related?
π Contextuele filters not respected when used in paragraph Active Possibly related? Comments reference the first issue.
- Status changed to Needs review
9 months ago 10:25pm 28 February 2024 - last update
9 months ago 1 pass - πΊπΈUnited States daletrexel Minnesota, USA
Uploading a patch for those who prefer it.
Also updating the status to Needs Review, since I believe this solves the problem and all that remains is confirmation that the approach meets approval.
- last update
9 months ago 1 pass - πΊπΈUnited States daletrexel Minnesota, USA
While investigating π Configuration schema for "Enable extra settings" (title,pagination,...) incorrect Fixed I've realized that the data field is what contains the extra settings for views reference fields, and as far as I can tell, only these fields. I've still not been able to figure out when there was a point that we would create paragraphs with views reference fields having null data fields, but it seems that the schema has been under flux. I went back as far as I could on Drupal 10 (beta 4) without being able to replicate the null data field, and the paragraphs throwing the deprecation error have very likely not been touched since we were on Drupal 9.
Regardless of whether the data key is always populated now, it still seems important to ensure we check for a non-null value before sending the data field to unserialize().
- πΊπΈUnited States daletrexel Minnesota, USA
After reviewing the comment timeline along with the recent beta releases, I'm confident that β¨ There is no display available. Please select another view or change the field settings. Needs review is directly related to this issue, especially in the most recent comment (prior to mine).
- Status changed to RTBC
7 months ago 7:10am 8 April 2024 - πΈπ°Slovakia coaston
Hello,
MR !43 or patch #4 worked for me.
Thank you
- ec21304b committed on 8.x-2.x
Issue #3423648 by DaleTrexel, coaston, seanB: unserialize() of NULL...
- ec21304b committed on 8.x-2.x
- Status changed to Fixed
7 months ago 8:10pm 8 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.